-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support nested filter specification types #757
support nested filter specification types #757
Conversation
Thanks for taking the time to open this PR! |
Hi @HarelM First of all, big thanks for your effort!
We are moving from mapbox-gl and I found some definition errors on our existing expressions so I thought I could collaborate updating their types definition (thanks again for moving to typescript! 🙇 ) Writing expressions has been always difficult for me, so typing them are even harder but I think we can have a generic solution to allow writing any kind of expression. And that is why I added a list of every filter available in the documentation
I thought the
Sure, let me accommodate and understand all and will keep you updated once they are ready
I haven't found any, but If that is the workflow I can create one explaining the error and point it here |
4f15f79
to
1435ba8
Compare
145ae9d
to
ad251ab
Compare
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
Please also fix the failing tests. |
8622791
to
b2c5a72
Compare
@HarelM all comments addressed, ready to review |
Thanks!!! |
Launch Checklist
maplibre-gl-js
changelog:<changelog></changelog>
.