chore: update node to 16

[birkskyum]

The current Node LTS is 16, bundling the npm v8 which use package-lock.json v2 format.

Update node to 16

[wipfli]

Thanks for taking the time to look into this. Currently, we recommend using nvm use 14, which keeps the problems with package lockfiles out of the way. Does nvm use 16 work with this codebase?

[wipfli]

If you update node and npm, please also edit https://github.com/maplibre/maplibre-gl-js/blob/main/CONTRIBUTING.md

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file	Before	After	Change
maplibre-gl.js	185 kB	185 kB	0 B
maplibre-gl.css	9.49 kB	9.49 kB	0 B

ℹ️ View Details

No major changes

[birkskyum]

The upstream node-canvas package supposedly have node 16 support since 2.8, but there appears to be some issues. When the upsteam is resolved, I'll try to run the maplibre-gl-js tests again.

[birkskyum]

@wipfli I bumped node-canvas and gl because their newer versions does have node 16 support. Can we rerun the tests?

[birkskyum]

Awesome! Let me know if anything is holding this back.

[HarelM]

I think the only thing holding this back is my hesitation to upgrade my dev env to node 16... :-(
Other than that, I think we should move forward. :-)

[birkskyum]

I think the only thing holding this back is my hesitation to upgrade my dev env to node 16... :-( Other than that, I think we should move forward. :-)

Great :) nvm to the rescue. I'll rebase the affected pr's to this branch then.

[birkskyum]

@wipfli , @astridx , @HarelM - I love what you have done to this repo since the fork - setting up a pipeline, typescript, jest etc. It's a big project, so if you can use an extra set of hands, I'd be happy to chip in.

[HarelM]

We'd appreciate any extra hands :-)
Let us know if you would like to be added as a maintainer.

[birkskyum]

We'd appreciate any extra hands :-) Let us know if you would like to be added as a maintainer.

Alright, that would be great actually :)

[HarelM]

Added as a maintainer. Godspeed!
Feel free to ping me in maplibre slack if you need to say something in private.
I'm pushing the button... :-)

[wipfli]

Welcome to MapLibre, Birk!