Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chalk #789

Merged
merged 5 commits into from Jan 20, 2022
Merged

Chalk #789

merged 5 commits into from Jan 20, 2022

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Jan 18, 2022

Launch Checklist

See #715

Output of npm run test-expressions

Before
2

After
1

I wonder why this change does not show up in package.lock. I have called npm ci. Is that OK for a removal?

  • [ x ] Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 185 kB 185 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB 0 B
ℹ️ View Details No major changes

@wipfli
Copy link
Member

wipfli commented Jan 19, 2022

Use npm uninstall chalk.

@birkskyum
Copy link
Member

Given that it's already removed from package.json, you will have to rebase to main and run npm install with node 16.

@astridx
Copy link
Contributor Author

astridx commented Jan 20, 2022

Thank you @wipfli and @birkskyum .
Now this should be fine.

@HarelM
Copy link
Member

HarelM commented Jan 20, 2022

What's the motivation on removing this package? It seems useful, isn't it?

@astridx
Copy link
Contributor Author

astridx commented Jan 20, 2022

What's the motivation on removing this package? It seems useful, isn't it?

Less dependencies . See #699 (comment)

@HarelM
Copy link
Member

HarelM commented Jan 20, 2022

Can you try using console.warn and console.error instead if yellow and red?

@astridx
Copy link
Contributor Author

astridx commented Jan 20, 2022

npm run test-expressions

I tried it, but it does not change the color in my console. See https://stackoverflow.com/questions/51449019/what-is-the-difference-between-console-log-and-console-error-in-js/51449060#51449060

@HarelM HarelM merged commit 6b57f36 into maplibre:main Jan 20, 2022
@astridx astridx deleted the chalk branch January 21, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants