Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs #991

wipfli · 2022-02-12T18:13:51Z

Launch Checklist

Possibly fixes #990. Let's try with a pre-release.

Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
Briefly describe the changes in this PR.
Include before/after visuals or gifs if this PR includes visual changes.
Write tests for all new functionality.
Document any changes to public APIs.
Post benchmark scores.
Manually test the debug page.
Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

github-actions · 2022-02-12T18:20:33Z

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file	Before	After	Change
maplibre-gl.js	185 kB	185 kB	0 B
maplibre-gl.css	9.43 kB	9.43 kB	0 B

ℹ️ View Details

No major changes

package.json

wipfli · 2022-02-12T18:47:29Z

Solutions with environment variables and || sometimes don't work on Windows. For now, we fix the issue by manually triggering the codegen stuff after install.

HarelM · 2022-02-12T18:52:38Z

package.json

@@ -171,7 +171,7 @@
    "codegen": "npm run generate-style-code && npm run generate-struct-arrays && npm run generate-style-spec && npm run generate-shaders",
    "benchmark": "node --loader ts-node/esm --experimental-specifier-resolution=node test/bench/run-benchmarks.ts",
    "gl-stats": "node --loader ts-node/esm --experimental-specifier-resolution=node test/bench/gl-stats.ts",
-    "postinstall": "npm run codegen && npm run generate-query-test-fixtures",
+    "dev-postinstall": "npm run codegen && npm run generate-query-test-fixtures",
    "prepare": "husky install"


I think husky might create problems as well.

check this out:
https://typicode.github.io/husky/#/?id=with-a-custom-script

I thought so too, but it is actually a dependency. ts-node is only a devDependency.

Why is husky a dependency? I don't think it should be...

HarelM

Make sure to mention in the title of the commit message the version bump to 2.1.3 so that we can easily see this when looking at the history.

* Migrate expression tests to jest (#965) * Revert "Move benchmarks to ES modules (#964)" (#969) This reverts commit aa8ed9d. * Migrate query tests from puppeteer to playwright (#966) * Fix web worker in watch mode (#968) * Fix web worker in watch mode * Add webworker support throughout * Don't change rollup for style-spec and benchmarks * Revert "Don't change rollup for style-spec and benchmarks" This reverts commit 62a7e14. * Remove duplicate node-resolve configuration * Simplify build pipeline (#961) * Remove build-tsc compile step * re-enable failing style-spec test * cleanup * cleanup * fix style-spec-test * Create codeql-analysis.yml * Bump simple-get from 3.1.0 to 3.1.1 (#971) Bumps [simple-get](https://github.com/feross/simple-get) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/feross/simple-get/releases) - [Commits](feross/simple-get@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: simple-get dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nanoid from 3.1.30 to 3.2.0 (#973) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.30...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cached-path-relative from 1.0.2 to 1.1.0 (#972) Bumps [cached-path-relative](https://github.com/ashaffer/cached-path-relative) from 1.0.2 to 1.1.0. - [Release notes](https://github.com/ashaffer/cached-path-relative/releases) - [Commits](https://github.com/ashaffer/cached-path-relative/commits) --- updated-dependencies: - dependency-name: cached-path-relative dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move browser test to playwright (#974) * Bump ts-node for 3x faster postinstall (#975) * Remove web worker replacement (#976) * Attribution default open for osm (#795) * Update CHANGELOG.md * Revert "Update CHANGELOG.md" This reverts commit 0b81a41. * attribution fixes (from astridx) a1272d9 b9b0370 * Update .gitignore * fix missing new line lint complained about * Revert "attribution fixes (from astridx)" This reverts commit 2031d8e. * Default compact to be open by default Default compact button to be open by default, to make OpenStreetMap attibutions to show by default like mentioned in ( #205 ) This uses an idea from ( #205 (comment) ) to show compact open by default, but close it when dragged. * remove test string I forgot to remove * fix compact button showing when there are no attributions * update whitespace trim to es6 syntax * fixes after testing various states of compact * revert back so it is open when starting in fullscreen * revert .gitignore * fix lint errors * fix tests Most of these fails because I made the compact button not show if attributes are empty. The other test fail because when switching between >640 and <=640 the open attribute is now added * lint * Update package-lock.json * Update package-lock.json * Update CHANGELOG.md * delete problematic files * put back deleted files * test/integration/assets/sprites/icon-text-fit-1x@2x.json * restore files Co-authored-by: acalcutt <acalcutt@worcester.edu> * Fix benchmarks (#984) * Move bench under `test` folder (#979) * Add typeof guard to performance variable (#986) * Fixes #768 * Fix comment and add changelog * Release 2.1.2 Version (#987) * Release 2.1.2 Version * Fix changelog according to comments * Fix release.yml due to bench folder move (#988) * lint function-url-quotes/ (#983) * Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs (#991) * Bump to v2.1.4 - Fix missing `postinstall.js` file in npm publish (#992) * Bump to v2.1.5-pre.1 - Publish empty `postinstall.js` file (#994) * Bump to v2.1.5 (#996) * Bump to v2.1.6-pre.1 - Fix `dist/package.json` (#998) * Bump to v2.1.6 (#999) * prefix (#1004) * correct done (#1006) * Add adjustment to rendering glyphs (#1005) * add topAdjustment for glyph * add topAdjustment for glyph * update changelog * add issue number * add alphabet and cjk text test #1002 * fix lint error * Simplify render tests (#1003) Fixes #1008 * Initial commit - half of the tests are failing * Missing file * Remove template rendering * Fix usage of localizeUrls * Move harness and server to render folder, simplify render code to be sepcific. * Move function outside and add some typings * lint * Add typings, move compare results outside * Remove server usage and replace it by file system reading. * Move xhr mocking to main flow * Move functions outside the render function * Move creation of tests to render.ts, added more typings * Move suite implementation into main flow file, add some typings. * lint * Moved all logic to a single file that runs the render tests * remove color from harness * Remove jest run command * Small fixes * lint * Cleanup * More cleanup * Remove harness and move it to a single file. Remove the jest version. * Remove ignore related code and tests * Remove ignore, add types * Add more types * lint * Migrate actual image generation to not use Buffer * lint * Fix CI run * Fix CI properly this time... * Revert png change * Revert only buffer usage * Revert png and buffer * Simplify png in mock file * Move to use uint8array and change throshold * Added diff info * remove specific threshold from test as it fails * Fix typo * Fix according to code review * Husky pre-commit do not fix lint (#1019) * Fix css * Use main package-lock.json Co-authored-by: Birk Skyum <74932975+birkskyum@users.noreply.github.com> Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Harel M <harel.mazor@gmail.com> Co-authored-by: Andrew Calcutt <acalcutt@techidiots.net> Co-authored-by: acalcutt <acalcutt@worcester.edu> Co-authored-by: vanilla-lake <95251033+vanilla-lake@users.noreply.github.com> Co-authored-by: Astrid <astridx@users.noreply.github.com> Co-authored-by: Kanahiro Iguchi <mediterranean1769@gmail.com>

Move postinstall codegen scripts to prepare hook

45ea581

HarelM reviewed Feb 12, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

HarelM reviewed Feb 12, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

wipfli changed the title ~~Move postinstall codegen scripts to prepare hook~~ Create custom script dev-postinstall and call it manually Feb 12, 2022

HarelM reviewed Feb 12, 2022

View reviewed changes

Check for 'development' env var in postinstall script

5eb6793

wipfli force-pushed the fix-postinstall branch from ae6072a to 5eb6793 Compare February 12, 2022 19:10

wipfli added 3 commits February 12, 2022 20:13

Remove dev-postinstall

b315e40

Make husky a dev dependency

bf0e960

Use production env var value

a10aadf

HarelM approved these changes Feb 12, 2022

View reviewed changes

wipfli changed the title ~~Create custom script dev-postinstall and call it manually~~ Bump to v2.1.3 - Fix postinstall error ts-node not found in non-dev installs Feb 12, 2022

wipfli merged commit b65fbdd into maplibre:main Feb 12, 2022

wipfli deleted the fix-postinstall branch February 12, 2022 19:27

This was referenced Feb 12, 2022

2.1.2 broken #990

Closed

Bump to v2.1.4 Fix missing postinstall.js file in npm publish #992

Merged

Bump to v2.1.5-pre.1 - Fix postinstall.js NODE_ENV check #993

Closed

Bump to v2.1.5-pre.1 - Publish empty postinstall.js file #994

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs #991

Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs #991

wipfli commented Feb 12, 2022

github-actions bot commented Feb 12, 2022 •

edited

wipfli commented Feb 12, 2022

HarelM Feb 12, 2022

HarelM Feb 12, 2022

wipfli Feb 12, 2022

HarelM Feb 12, 2022

HarelM left a comment

Bump to v2.1.3 - Fix postinstall error ts-node not found in non-dev installs #991

Bump to v2.1.3 - Fix postinstall error ts-node not found in non-dev installs #991

Conversation

wipfli commented Feb 12, 2022

Launch Checklist

github-actions bot commented Feb 12, 2022 • edited

wipfli commented Feb 12, 2022

HarelM Feb 12, 2022

Choose a reason for hiding this comment

HarelM Feb 12, 2022

Choose a reason for hiding this comment

wipfli Feb 12, 2022

Choose a reason for hiding this comment

HarelM Feb 12, 2022

Choose a reason for hiding this comment

HarelM left a comment

Choose a reason for hiding this comment

Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs #991

Bump to v2.1.3 - Fix postinstall error `ts-node` not found in non-dev installs #991

github-actions bot commented Feb 12, 2022 •

edited