Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularized Renderer: Android Beta Testing #1608

Closed
louwers opened this issue Sep 5, 2023 · 13 comments
Closed

Modularized Renderer: Android Beta Testing #1608

louwers opened this issue Sep 5, 2023 · 13 comments

Comments

@louwers
Copy link
Collaborator

louwers commented Sep 5, 2023

The internals of MapLibre Native have received a big redesign. This brings many advantages to the project, most notably that it allows for other rendering backends, but aside from that we expect performance gains, and much better extendibility.

This is the future of MapLibre. Eventually, the code of the legacy renderer will be removed. Therefore it is very important that all users of MapLibre Native pitch in to test the pre-releases of MapLibre Native that will include this new renderer.

Is the functionality that is important for you still working? Are there any problems with the styles that you use? Do you see any performance regressions? We have a lot of tests, but the real test is trying it out in real projects.

The pre-release for MapLibre Native Android 11.0.0 is out now!

dependencies {
        implementation("org.maplibre.gl:android-sdk:11.0.0-pre4")
}

Reporting Issues

When report an issue, the following are required:

  • Style: If your style is public or can be made available, that will help a lot.
  • Lat / Long / Zoom: Where exactly does the issue occur?
  • Screenshot
  • Android version
  • Device

When available:

  • Stack Trace / Metal Error / Core Dump
  • Minimal style: Can you provide a minimal style that reproduces the issue?
@mtpdog
Copy link

mtpdog commented Dec 3, 2023

This is awesome!
Could you please explain how can we test this beta?
I think it is important to test that everything works fine before this important transition takes place.

@louwers
Copy link
Collaborator Author

louwers commented Dec 3, 2023

@mtpdog Please subscribe to this thread (you should be now that you left a message). I will post a message here to notify you once it is released.

If you want to build it yourself ahead of the pre-release:

cd platform/android
./gradlew assembleDrawable

@louwers
Copy link
Collaborator Author

louwers commented Feb 28, 2024

The MapLibre Native Android 11.0.0 pre-release is out now. Please see the changelog.

There have been changes to the internal rendering architecture, so please check if your application / style still works correctly and report any issues you enounter. Instructions for reporting issues are in the first post.

@michalgwo
Copy link

michalgwo commented Feb 28, 2024

Do you plan to update also maplibre-plugins-android and maplibre-navigation-android? I'm not able to run the new maplibre-native version with old versions of these libraries, as they require classes from com.mapbox.mapboxsdk package.

For example in the annotation plugin to create SymbolManager SymbolManager(mapView, map, style), all parameters requires com.mapbox.mapboxsdk package, which is not available in the new MapLibre version.

One example in maplibre-navigation-android would be creating LocationComponentActivationOptions:

LocationComponentActivationOptions.builder(this, style)
    .locationComponentOptions(locationComponentOptionsBuilder.build())
    .locationEngine(LocationEngineProvider.getBestLocationEngine(this))
    .locationEngineRequest(locationEngineRequest)
    .build()

.locationEngine() requires maplibre package, but LocationEngineProvider.getBestLocationEngine(this) returns mapbox package

@louwers
Copy link
Collaborator Author

louwers commented Feb 28, 2024

@michalgwo Absolutely. I created two issues:

maplibre/maplibre-navigation-android#104

maplibre/maplibre-plugins-android#49

I'll have a look at it before the final release if no-one else picks it up.

@louwers
Copy link
Collaborator Author

louwers commented Mar 2, 2024

org.maplibre.gl:android-sdk:11.0.0-pre2 was released which includes the Asynchronous GeometryTile deletion (#2051) PR.

@louwers
Copy link
Collaborator Author

louwers commented Mar 2, 2024

Please use org.maplibre.gl:android-sdk:11.0.0-pre3 from Maven Central as 11.0.0-pre2 was a Debug build by accident (still fixing the automated release pipeline).

@westnordost
Copy link

westnordost commented Mar 18, 2024

I found something peculiar in 11.0.0-pre4. Didn't test if it is reproducible in 10.x

Occurs quite rarely, maybe if the tile just loaded?

Buildings in the style used fade out at a certain zoom level. You see in the video that instead they seem to fade to black rarely:

Screen.Recording.20240319.004941.mp4

@louwers
Copy link
Collaborator Author

louwers commented Mar 28, 2024

@westnordost That doesn't look right. Also when you zoom in to new areas I see it getting darker for a split second until the tiles are loaded.

Another issue with the location indicator popped up:

#2216

So it looks like we need to hold off on the 11.0.0 release for a bit longer.

@louwers
Copy link
Collaborator Author

louwers commented Mar 28, 2024

@westnordost Does this look kind of similar? #2217

@westnordost
Copy link

westnordost commented Mar 28, 2024

Hm, it looks a bit similar, but this issue I can only reproduce when zooming out. #2217 I have not seen yet at all.

Might be style-specific?

In case it is relevant, the style used in the app is https://github.com/streetcomplete/maplibre-streetcomplete-style (you find the style json in the demo folder).

The app adds some additional layers, but e.g. the layer with the rendering bug is not modified by the app in any way.

@louwers louwers added this to the Android 11.0.0 milestone Apr 10, 2024
@louwers
Copy link
Collaborator Author

louwers commented Apr 19, 2024

@westnordost Could you try the new pre-release and check if the zooming issue has been fixed?

@louwers
Copy link
Collaborator Author

louwers commented May 8, 2024

The 11.0.0 release is out. https://github.com/maplibre/maplibre-native/releases/tag/android-v11.0.0

Thanks to everyone that helped with testing.

@louwers louwers closed this as completed May 8, 2024
@louwers louwers unpinned this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants