Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux tests + coverage report with Bazel #1139

Merged
merged 24 commits into from
May 15, 2023

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented May 13, 2023

Just trying out Bazel and exploring the build setup.

Two C++ unit tests now can be run with:

bazel test //test:core

@louwers louwers added the build Related to build, configuration or CI/CD label May 13, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@louwers louwers changed the title Linux tests running with Bazel Linux tests + coverage report with Bazel May 14, 2023
@github-actions

This comment has been minimized.

@louwers
Copy link
Collaborator Author

louwers commented May 14, 2023

I wanted to use the new Platforms functionality to configure which headers include and which flags to pass etc. but it turns out rules_apple does not have support for it yet: bazelbuild/rules_apple#1658

I need to find some workaround.

@louwers louwers marked this pull request as ready for review May 14, 2023 22:21
@louwers
Copy link
Collaborator Author

louwers commented May 14, 2023

codecov.io needs to be enabled, but I don't have organization access. So the upload will fail.

I also need to enable all tests. It's just one now to get everything running end-to-end.
I'll add the rest in a separate PR.

platform/linux/BUILD.bazel Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4ebb7c5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1139   +/-   ##
=======================================
  Coverage        ?   63.15%           
=======================================
  Files           ?      588           
  Lines           ?    31991           
  Branches        ?        0           
=======================================
  Hits            ?    20203           
  Misses          ?    11788           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

This comment has been minimized.

platform/linux/BUILD.bazel Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

@github-actions
Copy link

Size test result

Old size: 8891216 bytes
New size: 8887808 bytes
Difference: +0.04%

@louwers louwers merged commit 824199f into maplibre:main May 15, 2023
23 checks passed
@louwers louwers deleted the linux-one-test-bazel branch May 15, 2023 17:42
stefankarschti pushed a commit to stefankarschti/maplibre-native that referenced this pull request May 23, 2023
stefankarschti pushed a commit to stefankarschti/maplibre-native that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants