-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android annotations: implement new Symbol
class
#1637
Android annotations: implement new Symbol
class
#1637
Conversation
Why are existing tests commented out? These are only tests for functionality that was marked as deprecated, right? |
@louwers I had to comment out the following classes:
This was needed to make changes to These classes have been commented out because they will be removed, but are still useful for reference in the next step:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @fynngodau, that makes sense.
@artakka Any chance you can help me review the Kotlin code added in this PR?
...oid/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/annotations/AnnotationContainer.kt
Outdated
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/annotations/AnnotationContainer.kt
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/annotations/AnnotationContainer.kt
Outdated
Show resolved
Hide resolved
platform/android/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/annotations/Circle.java
Show resolved
Hide resolved
Some questions and suggestions, but overall looks good! |
Android annotations API proposal implementation PR as a part of #1491. Closes #1493.
Symbol
class is now usable.SymbolManager
have been updated, and pass.Symbol
→KSymbol
Annotation
→KAnnotation
AnnotationContainer
→KAnnotationContainer