Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android benchmark on CI #1905

Merged
merged 59 commits into from
Dec 7, 2023
Merged

Android benchmark on CI #1905

merged 59 commits into from
Dec 7, 2023

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Nov 30, 2023

  • Update Kotlin and the Android Gradle plugin version as well, because I was running into build issues when adding kotlinx.serialization as a dependency of the test app.
  • Allow benchmark to be run with instrumentation test (uses Benchmark activity from Benchmark activity Android #1850)
  • Make JSON payload for benchmark results to send to the API
  • I created a custom test environment so that we can run the UI tests independently from the benchmarks.
  • Instead of baking the input for the benchmark at build time, it will read abenchmark-input.json with the style names, style URLs and the results API. For now the benchmarks are just built and an artifact is created.

benchmark-input.json

{
  "styleNames": ["Facebook Light", "MapTiler Basic", "Americana"],
  "styleURLs": [
    "https://xxx",
    "https://xxx",
    "https://xxx"
  ],
  "resultsAPI": "https://xxx"
}```

On a follow up PR I will actually run them and report the results back on a PR.

louwers and others added 30 commits November 8, 2023 12:58
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alex Cristici <alex.cristici@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: mwilsnd <53413200+mwilsnd@users.noreply.github.com>
Co-authored-by: Marc Regan <1158294+marcregan@users.noreply.github.com>
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
…ibre#1877)

Co-authored-by: Christophe Brasseur <christophe.brasseur@geolives.com>
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
Co-authored-by: Bart Louwers <bart@emeel.net>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@louwers louwers changed the title Android benchmark2 Android benchmark on CI Nov 30, 2023
@louwers louwers added github_actions Pull requests that update GitHub Actions code android labels Nov 30, 2023
Copy link

github-actions bot commented Nov 30, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1905-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18% +21.4Mi  +399% +23.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1905-compared-to-legacy.txt

@louwers louwers marked this pull request as ready for review December 5, 2023 16:30
@louwers louwers self-assigned this Dec 5, 2023
@louwers louwers merged commit 27cd953 into maplibre:main Dec 7, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android github_actions Pull requests that update GitHub Actions code ⚡ performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants