[node][opengl-2] Update workflow for node 21 + allow publish from opengl-2 branch #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mwilsnd <mwilsnd@gmail.com>
I changed this a long time ago, but this build will never succeed and this should be false
|
I think we should just merge the two Node workflows. Here the the frequency of PRs is so low that we can afford also running Linux and Windows. |
|
@ntadej I installed it on the Ubuntu ARM runner... Also installed on macOS now. |
|
I tried to re-run that macos arm64 job that failed to see if it would pick up the update, but it still failed. I'm not sure it would pick up the new changes yet though. |
|
I'll merge this. We can fix the missing fonts in parallel as I think this has already been failing earlier. |
acalcutt
added a commit
to WifiDB/maplibre-native
that referenced
this pull request
Dec 31, 2023
…ngl-2 branch (maplibre#1941) Co-authored-by: mwilsnd <mwilsnd@gmail.com> Co-authored-by: Bart Louwers <bart@emeel.net>
acalcutt
added a commit
to WifiDB/maplibre-native
that referenced
this pull request
Dec 31, 2023
…ngl-2 branch (maplibre#1941) Co-authored-by: mwilsnd <mwilsnd@gmail.com> Co-authored-by: Bart Louwers <bart@emeel.net>
This was referenced Dec 31, 2023
acalcutt
added a commit
to WifiDB/maplibre-native
that referenced
this pull request
Jan 6, 2024
…ngl-2 branch (maplibre#1941) Co-authored-by: mwilsnd <mwilsnd@gmail.com> Co-authored-by: Bart Louwers <bart@emeel.net>
acalcutt
added a commit
to WifiDB/maplibre-native
that referenced
this pull request
Jan 8, 2024
…ngl-2 branch (maplibre#1941) Co-authored-by: mwilsnd <mwilsnd@gmail.com> Co-authored-by: Bart Louwers <bart@emeel.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a node release to be published from the 'opengl-2' branch. This would be run by selecting the 'opengl-2' branch when running then workflow
Changes
Cherry Picks