[bazel] Run nodejs inside of bazel for genrules

[keith]

This fixes #1910 by using rules_js.

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1948-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18% +21.4Mi  +399% +23.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1948-compared-to-legacy.txt

[louwers]

Should we maybe stick to package-lock.json so we don't have two separate lockfiles?

[keith]

Unfortunately I think that's a requirement of these rules, but I'm asking around to see if that interpretation is true

[keith]

this currently includes #1956

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-1948-compared-to-main.txt

[keith]

ok once we merge the 7.x bump and I rebase this I think it will look good!

[keith]

As is this fixes #2009 by replacing the umbrella header with one generated by bazel, and taking some part of #2010. This probably results in the import being different for folks using #import <MapLibre/MapBox.h> syntax, but I think for folks using @import MapLibre (or from Swift) there is no noticeable difference in that. This does remove some headers as is that we might want to add back though:

--- /dev/fd/63	2024-01-29 14:06:43
+++ /dev/fd/62	2024-01-29 14:06:43
@@ -1,5 +1,4 @@
 MLNAnnotation.h
-MLNAnnotationContainerView.h
 MLNAnnotationImage.h
 MLNAnnotationView.h
 MLNAttributedExpression.h
@@ -10,15 +9,13 @@
 MLNCircleStyleLayer.h
 MLNClockDirectionFormatter.h
 MLNCluster.h
-MLNCompactCalloutView.h
 MLNCompassButton.h
 MLNCompassDirectionFormatter.h
 MLNComputedShapeSource.h
-MLNConversion.h
 MLNCoordinateFormatter.h
+MLNCustomDrawableStyleLayer.h
 MLNDefaultStyle.h
 MLNDistanceFormatter.h
-MLNFaux3DUserLocationAnnotationView.h
 MLNFeature.h
 MLNFillExtrusionStyleLayer.h
 MLNFillStyleLayer.h
@@ -32,14 +29,10 @@
 MLNLineStyleLayer.h
 MLNLocationManager.h
 MLNLoggingConfiguration.h
-MLNMapAccessibilityElement.h
 MLNMapCamera.h
 MLNMapProjection.h
 MLNMapSnapshotter.h
 MLNMapView+IBAdditions.h
-MLNMapView+Impl.h
-MLNMapView+Metal.h
-MLNMapView+OpenGL.h
 MLNMapView.h
 MLNMapViewDelegate.h
 MLNMultiPoint.h
@@ -47,6 +40,7 @@
 MLNOfflinePack.h
 MLNOfflineRegion.h
 MLNOfflineStorage.h
+MLNOpenGLStyleLayer.h
 MLNOverlay.h
 MLNPointAnnotation.h
 MLNPointCollection.h
@@ -55,10 +49,6 @@
 MLNRasterDEMSource.h
 MLNRasterStyleLayer.h
 MLNRasterTileSource.h
-MLNReachability.h
-MLNRendererConfiguration.h
-MLNRendererFrontend.h
-MLNScaleBar.h
 MLNSettings.h
 MLNShape.h
 MLNShapeCollection.h
@@ -67,7 +57,6 @@
 MLNSource.h
 MLNStyle.h
 MLNStyleLayer.h
-MLNStyleLayerManager.h
 MLNStyleValue.h
 MLNSymbolStyleLayer.h
 MLNTilePyramidOfflineRegion.h
@@ -77,30 +66,10 @@
 MLNUserLocation.h
 MLNUserLocationAnnotationView.h
 MLNUserLocationAnnotationViewStyle.h
-MLNUserLocationHeadingArrowLayer.h
-MLNUserLocationHeadingBeamLayer.h
-MLNUserLocationHeadingIndicator.h
-MLNValueEvaluator.h
 MLNVectorStyleLayer.h
 MLNVectorTileSource.h
+MapLibre.h
 Mapbox.h
-NSArray+MLNAdditions.h
-NSBundle+MLNAdditions.h
-NSCoder+MLNAdditions.h
-NSComparisonPredicate+MLNAdditions.h
-NSCompoundPredicate+MLNAdditions.h
-NSDate+MLNAdditions.h
-NSDictionary+MLNAdditions.h
-NSException+MLNAdditions.h
 NSExpression+MLNAdditions.h
-NSOrthography+MLNAdditions.h
 NSPredicate+MLNAdditions.h
-NSString+MLNAdditions.h
-NSURL+MLNAdditions.h
 NSValue+MLNAdditions.h
-NSValue+MLNStyleAttributeAdditions.h
-UIColor+MLNAdditions.h
-UIDevice+MLNAdditions.h
-UIImage+MLNAdditions.h
-UIView+MLNAdditions.h
-UIViewController+MLNAdditions.h

[keith]

@louwers fun one for you

[louwers]

This looks good to me.

This does remove some headers as is that we might want to add back though:

I think these are intended to be private headers. If someone complains though, it will be pretty easy to fix.

This probably results in the import being different for folks using #import <MapLibre/MapBox.h> syntax

I think before the 6.0.0 release it used to be #import <Mapbox.h>. It was not intended to change to MapLibre/Mapbox.h... But @import MapLibre should be the prefered way to consume the library.

One question though: what steps are needed to update npm packages now?

[keith]

So when node packages are updated now the build will fail CI until this new file is re-sync'd with:

bazel run -- @pnpm//:pnpm --dir $PWD install --lockfile-only

[bsudekum]

Hey folks, can we merge this one?

[keith]

@louwers want to merge this one?

[louwers]

@keith @bsudekum Yes! Thanks for the reminder (am out of office, back this Friday). 🙏