Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Allow setting padding when camera is tracking #2165

Merged
merged 2 commits into from Mar 4, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Mar 3, 2024

This is a port of mapbox/mapbox-gl-native-android@928cd57 This code was released under the same license as that of MapLibre Native (Android).

Closes #2138

Request to create this ticket came from @hy9be. I decided to pick it up because I want to become more familiar with the Android development process and make some quality of life improvements.

This is supposed to make tracking while navigating more familiar and natural.

@louwers louwers added enhancement New feature or request android labels Mar 3, 2024
@louwers louwers requested a review from artakka March 3, 2024 19:22
@louwers louwers self-assigned this Mar 3, 2024
Copy link
Collaborator

@boldtrn boldtrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me, I haven't performed any actual testing yet, so I feel kind of bad to approve this PR :).

@louwers
Copy link
Collaborator Author

louwers commented Mar 4, 2024

@boldtrn I didn't wrote it, it's a port so it was already reviewed. :)

@louwers louwers merged commit 69f983b into maplibre:main Mar 4, 2024
15 checks passed
louwers added a commit to louwers/maplibre-native that referenced this pull request Mar 15, 2024
louwers added a commit to louwers/maplibre-native that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Allow setting padding when camera is tracking
4 participants