Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes setURL method on MLNImageSource public #2197

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

manuelroth
Copy link
Contributor

@manuelroth manuelroth commented Mar 14, 2024

This PR makes the setURL method on the MLNImageSource public. This is required to be able to dynamically update the url of an existing image source. The Android SDK already provides such a method (see setUri for more details). Until now this use case could only be addressed by creating a new source when ever the url changed and deleting the "old" source which resulted in bad performance of the app. The setURL method would greatly improve the implementation of this use case.

Please let me know if I can improve anything. I am not an Objective-C developer. Therefore any hints on improvements are greatly appreciated.

@louwers louwers added the iOS label Mar 14, 2024
@louwers louwers self-requested a review March 14, 2024 21:46
@louwers louwers added the enhancement New feature or request label Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2197-compared-to-main.txt

Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
@louwers louwers enabled auto-merge (squash) March 14, 2024 22:50
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. :)

Will be included in the next release along with your other PR. Let me know if you need it soon, then I can push out a release.

@manuelroth
Copy link
Contributor Author

Thank you very much for reviewing my PR. It is awesome to contribute in this way. I really appreciate it. Unfortunately we are currently blocked from upgrading to MapLibre v6 by this issue reported by my teammate: #2189. Would it be feasible to create another v5 release with this changes in addition to a v6 release?- So we could already take advantage of this change while a solution for the issue #2189 can be found. If its too much effort it is also fine. Of course we want to upgrade to v6 as soon as possible, but for the moment we unfortunately cannot.

@louwers louwers merged commit 4bf99d8 into maplibre:main Mar 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants