Makes setURL
method on MLNImageSource public
#2197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
setURL
method on the MLNImageSource public. This is required to be able to dynamically update the url of an existing image source. The Android SDK already provides such a method (see setUri for more details). Until now this use case could only be addressed by creating a new source when ever the url changed and deleting the "old" source which resulted in bad performance of the app. ThesetURL
method would greatly improve the implementation of this use case.Please let me know if I can improve anything. I am not an Objective-C developer. Therefore any hints on improvements are greatly appreciated.