Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional leaks #2257

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Additional leaks #2257

merged 1 commit into from
Apr 11, 2024

Conversation

TimSylvester
Copy link
Collaborator

Follow-up to #2254, the screenshot provided also shows a leak indicator on MTLCompileOptionsInternal, which appears to be from the same problem in another location.

@TimSylvester TimSylvester added bug Something isn't working metal labels Apr 11, 2024
@TimSylvester TimSylvester self-assigned this Apr 11, 2024
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2257-compared-to-main.txt

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2257-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.0Mi  +405% +24.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2257-compared-to-legacy.txt

@TimSylvester TimSylvester marked this pull request as ready for review April 11, 2024 20:11
Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0031         -0.0030             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2257-compared-to-main.txt

@louwers louwers enabled auto-merge (squash) April 11, 2024 20:18
@louwers louwers merged commit ae88ac9 into maplibre:main Apr 11, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metal
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants