-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use blending for basic fill layers #2296
Conversation
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2296-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2296-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2296-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2296-compared-to-main.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, if an alpha value is specified it's hard to imagine how we could get correct results without using it, but there is a clear intent to do that sometimes in legacy so I have a suspicion that there might be an even more obscure bug lurking there.
Seems to be fixed!! |
Compared with the legacy renderer, we should always be using alpha blending for simple fill layers. I'm unable to replicate #2217 at the moment, unsure if this change will also address that issue.
Replicate with FB style, GLFW platform, press 'O' to toggle off online connectivity to permit sustained overzoom of fill layers which do overzoom color interpolation.
Before:
After