Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use blending for basic fill layers #2296

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

mwilsnd
Copy link
Collaborator

@mwilsnd mwilsnd commented Apr 18, 2024

Compared with the legacy renderer, we should always be using alpha blending for simple fill layers. I'm unable to replicate #2217 at the moment, unsure if this change will also address that issue.

Replicate with FB style, GLFW platform, press 'O' to toggle off online connectivity to permit sustained overzoom of fill layers which do overzoom color interpolation.

Before:
mbgl-glfw_dMW5NvjdRU

After
image

@mwilsnd mwilsnd self-assigned this Apr 18, 2024
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2296-compared-to-main.txt

@mwilsnd mwilsnd added the bug Something isn't working label Apr 18, 2024
Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -432  -0.0%    -344    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2296-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.3Mi  +406% +24.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2296-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0023         +0.0027             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2296-compared-to-main.txt

@mwilsnd mwilsnd assigned alexcristici and unassigned alexcristici Apr 18, 2024
@mwilsnd mwilsnd marked this pull request as ready for review April 18, 2024 20:56
Copy link
Collaborator

@TimSylvester TimSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if an alpha value is specified it's hard to imagine how we could get correct results without using it, but there is a clear intent to do that sometimes in legacy so I have a suspicion that there might be an even more obscure bug lurking there.

@louwers
Copy link
Collaborator

louwers commented Apr 19, 2024

Seems to be fixed!!

@louwers louwers linked an issue Apr 19, 2024 that may be closed by this pull request
@louwers louwers merged commit aceed41 into maplibre:main Apr 19, 2024
33 checks passed
@louwers louwers deleted the fill-blending branch April 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map darkens when zooming in and tiles are loaded
4 participants