Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename master -> main in CI and build scripts #246

Merged
merged 1 commit into from Mar 7, 2022

Conversation

atierian
Copy link
Contributor

@atierian atierian commented Mar 5, 2022

Issue:
maplibre/maplibre#11

Changes:
This PR makes a best effort to change all CI and related build scripts from using master to main.

Explicitly excluded from changes:

  • **/vendor
  • Any **/mapbox/** links. While the majority of these could be renamed already, it would make more sense to handle these changes while updating the links to point at maplibre.
  • Any occurrences of master in links to third party licenses.
  • Any occurrences of master in functional code.

Once this is merged, we can take the remaining steps listed in the linked issue to complete the rename.

@roblabs roblabs merged commit ea234ed into maplibre:master Mar 7, 2022
@roblabs
Copy link
Collaborator

roblabs commented Mar 7, 2022

@atierian — Just realized: The GitHub workflow won't kick off because the touched files are in the ignore list for triggering a GitHub Workflow. So we'll monitor this after the next PR.

OR, do you recommend committing something (say in a SwiftUI test app) that will trigger all the builds.?

@ntadej
Copy link
Collaborator

ntadej commented Mar 7, 2022

I think the problem is rather that the trigger branches in the CI configs were switched to main already.

@atierian
Copy link
Contributor Author

atierian commented Mar 7, 2022

Another option would be:

  1. Reverting the commit
  2. Changing the branch name
  3. Merging this reverted commit.

If the files are in the GitHub action / workflow ignore list, the tests can be manually triggered.

Since this PR touches so many files, I'd like to make sure CI is working as expected before any code changes get merged to main.

@roblabs
Copy link
Collaborator

roblabs commented Mar 7, 2022

Let's try the manual trigger method. Under the checks section of a PR, I usually see a way to rebuild, but I don't see that for this one.

If there is another way to trigger, please let me know.

@ntadej
Copy link
Collaborator

ntadej commented Mar 7, 2022

Directly from Actions (one by one). I did that for all *-ci ones now.

@roblabs
Copy link
Collaborator

roblabs commented Mar 7, 2022

Thanks @ntadej — I see it now, and thanks for kicking off those actions

keith pushed a commit to lyft/maplibre-gl-native that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants