Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vector-tile to MapLibre fork #2460

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Update vector-tile to MapLibre fork #2460

merged 2 commits into from
Jun 3, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Jun 3, 2024 •
edited
Loading

Updates the vector-tile vendored dependency to use the MapLibre fork hosted at https://github.com/maplibre/mvt-cpp

Includes a commit cherry-picked by @nathreed maplibre/mvt-cpp#2

Closes #795

Style Metric mvt-cpp vector-tiles
Americana avgEncodingTime 13.0449364383 13.9205717752
Americana low1pEncodingTime 59.4919468571 63.3725865995
Americana avgRenderingTime 12.2574985444 12.8400150678
Americana low1pRenderingTime 37.3708819947 36.2964980954

Also some progress towards #2227

@louwers louwers added bug Something isn't working dependencies Pull requests that update a dependency file cpp-core labels Jun 3, 2024
@louwers louwers self-assigned this Jun 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -552  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2460-compared-to-main.txt

@louwers louwers requested a review from cgalvan June 3, 2024 13:58
@louwers louwers mentioned this pull request Jun 3, 2024
Closed
@louwers louwers requested a review from HarelM June 3, 2024 16:22
@louwers louwers merged commit c961eb0 into maplibre:main Jun 3, 2024
31 of 32 checks passed
@louwers louwers deleted the update-vector-tile branch June 3, 2024 16:27
acalcutt pushed a commit to WifiDB/maplibre-native that referenced this pull request Jun 4, 2024
@louwers @acalcutt
Update vector-tile to MapLibre fork (maplibre#2460)
42eda2b
acalcutt added a commit to WifiDB/maplibre-native that referenced this pull request Jun 4, 2024
@acalcutt
Update vector-tile to MapLibre fork (maplibre#2460)
961c698
@acalcutt acalcutt mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

@alexcristici alexcristici Awaiting requested review from alexcristici

@mwilsnd mwilsnd Awaiting requested review from mwilsnd

@TimSylvester TimSylvester Awaiting requested review from TimSylvester

@cgalvan cgalvan Awaiting requested review from cgalvan

Assignees

@louwers louwers

Labels
bug Something isn't working cpp-core dependencies Pull requests that update a dependency file
Projects
MapLibre Native Core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error: feature referenced out of range key
2 participants
@louwers @HarelM