Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal base vertex instance drawing disabled on GPUFamilyApple2 devices #2470

Merged

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Jun 4, 2024

Disabled base vertex instance drawing on GPUFamilyApple2 devices.

Note: baseVertex could be different than 0 for some styles, so we need to fix this use case in a future PR.

@alexcristici alexcristici self-assigned this Jun 4, 2024
@alexcristici alexcristici linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 4, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +216  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2470-compared-to-main.txt

Copy link

github-actions bot commented Jun 4, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2470-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2470-compared-to-legacy.txt

Copy link

github-actions bot commented Jun 4, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0652         -0.0648             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2470-compared-to-main.txt

@alexcristici alexcristici marked this pull request as ready for review June 4, 2024 15:54
@alexcristici alexcristici changed the title Metal instance drawing made optional Metal instance drawing disabled on GPUFamilyApple2 devices Jun 4, 2024
@alexcristici alexcristici changed the title Metal instance drawing disabled on GPUFamilyApple2 devices Metal base vertex instance drawing disabled on GPUFamilyApple2 devices Jun 4, 2024
@louwers louwers merged commit 410d706 into maplibre:main Jun 5, 2024
33 of 34 checks passed
@alexcristici alexcristici deleted the metal-instance-drawing-made-optional branch June 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Crash on iPadOS 15.8.x
4 participants