Compile Node targets without -std=c++11 option #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcosta100
changed the title
louwers
approved these changes
Mar 22, 2023
|
Thanks @tdcosta100. |
|
Thanks @tdcosta100, this fixed some compilation issues I had recently! |
|
Nice, @stefankarschti! It was giving me some errors too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
-std=c++11switch configured in Node modules here. I can imagine this was put there because of older compilers. Now we have C++17, this is a limiting option, not a better one. This PR removes this option in Node targets.