Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route snap example #73

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

Fabi755
Copy link
Collaborator

@Fabi755 Fabi755 commented Jul 19, 2023

This PR will add some basic route snapping example. It's very simple. The route is fixed and navigation starts automatically.

I need this example as a show case for a bug in the default route snap engine. This is the reason that I will split the markdown documentation and example implementation in two PRs.

@Fabi755
Copy link
Collaborator Author

Fabi755 commented Jul 19, 2023

Do we want all changes of example app in the changelog as well?

@boldtrn
Copy link
Collaborator

boldtrn commented Jul 20, 2023

Thanks a lot for this PR :)

Do we want all changes of example app in the changelog as well?

I'd say no, as this has no actual influence for other implementations. We could mention it, but I don't hink it's necessary.

Copy link
Collaborator

@boldtrn boldtrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this sample, this seems to be working fine and will help users understand how to implement navigation 👍

@Fabi755
Copy link
Collaborator Author

Fabi755 commented Jul 25, 2023

Sounds good! From my side we can merge this.

@boldtrn boldtrn merged commit 61df527 into maplibre:main Jul 25, 2023
2 checks passed
@boldtrn
Copy link
Collaborator

boldtrn commented Jul 25, 2023

Thanks again for creating these great PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants