Fixes for API 34 #90
Merged
Fixes for API 34 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabi755
reviewed
Oct 27, 2023
|
Hi, sorry for slow reply, have added entry to CHANGELOG now |
|
Thanks a lot for the PR! |
Fabi755
reviewed
Nov 14, 2023
| @@ -151,7 +151,7 @@ private PendingIntent createPendingOpenIntent(Context context) { | |||
|
|
|||
| private void registerReceiver(Context context) { | |||
| if (context != null) { | |||
| context.registerReceiver(endNavigationBtnReceiver, new IntentFilter(END_NAVIGATION_ACTION)); | |||
| context.registerReceiver(endNavigationBtnReceiver, new IntentFilter(END_NAVIGATION_ACTION), Context.RECEIVER_NOT_EXPORTED); | |||
There was a problem hiding this comment.
May bad, I seeing this too late. This call of registerReceiver is only available for API +26.
There was a problem hiding this comment.
I'm currently investigate some time in #94. And will fix this too on this way.
There was a problem hiding this comment.
Thanks for investigating @Fabi755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two crashes occuring when attempting to use the MockNavigationActivity on Android API 34:
java.lang.SecurityException: com.mapbox.services.android.navigation.testapp: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcastsjava.lang.SecurityException: Starting FGS with type location callerApp=ProcessRecord{a043266 10859:com.mapbox.services.android.navigation.testapp/u0a410} targetSDK=34 requires permissions: all of the permissions allOf=true [android.permission.FOREGROUND_SERVICE_LOCATION] any of the permissions allOf=false [android.permission.ACCESS_COARSE_LOCATION, android.permission.ACCESS_FINE_LOCATION] and the app must be in the eligible state/exemptions to access the foreground only permission