Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update robolectric and mockito to fix unit tests #36

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Update robolectric and mockito to fix unit tests #36

merged 3 commits into from
Jun 22, 2023

Conversation

JonasVautherin
Copy link
Collaborator

@JonasVautherin JonasVautherin commented Jun 21, 2023 •
edited
Loading

Should fix the remaining tests.

  • All but one were fixed by updating roboelectric and mockito (so this is a safe change)
  • One was failing on a call I don't understand, that internally calls some geoJson stuff (which I removed in many places in a previous PR because 20 tests were failing too, for a reason I also don't understand). Honestly I don't understand it, I just removed as little as possible to make the tests pass.
  • After all the previous tests passed, Gradle moves on to building more tests, and one of them failed to build. I fixed that, too.

EDIT: now it passes 🎉

@fynngodau @louwers: happy to get a review 😊

@fynngodau fynngodau self-requested a review June 22, 2023 04:28
@JonasVautherin JonasVautherin mentioned this pull request Jun 22, 2023
Merged
fynngodau
fynngodau requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear the tests are in a better shape than before!

...src/test/java/com/mapbox/mapboxsdk/plugins/annotation/DraggableAnnotationControllerTest.java Show resolved Hide resolved
@fynngodau fynngodau mentioned this pull request Jun 22, 2023
Merged
fynngodau
fynngodau approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fynngodau fynngodau merged commit 733ee86 into maplibre:main Jun 22, 2023
1 check passed
@JonasVautherin JonasVautherin deleted the upstream-fix-robolectric-tests branch June 22, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fynngodau fynngodau fynngodau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasVautherin @fynngodau