Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dragging ordering #47

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix dragging ordering #47

merged 1 commit into from
Nov 7, 2023

Conversation

JonasVautherin
Copy link
Collaborator

@JonasVautherin JonasVautherin commented Aug 13, 2023 •
edited
Loading

Resolves #44.

This now orders the annotationManagers according to their vertical order (using the belowLayer and aboveLayer).

Tested by @RomanBapst and I (on two different apps, both with ramani-maps and a pure Maplibre-Android app).

See the sample code of #44 with the fix here:

fix-dragging-ordering.mp4

@JonasVautherin
Copy link
Collaborator Author

Kindly pinging on that front 😊

louwers
louwers approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Normally a regression test would be ideal, but seeing as we're moving the annotations into the core library again not sure if that is worth the trouble.

@JonasVautherin JonasVautherin merged commit 541c878 into maplibre:main Nov 7, 2023
1 check passed
@JonasVautherin JonasVautherin deleted the upstream-fix-dragging-ordering branch November 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers approved these changes

@fynngodau fynngodau Awaiting requested review from fynngodau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation dragging does not respect the layer order
2 participants
@JonasVautherin @louwers