Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages names updates #55

Merged
merged 41 commits into from
May 20, 2024
Merged

Conversation

kocheick
Copy link
Contributor

@kocheick kocheick commented May 15, 2024

packages and names updated ~ #52

By the way, just pointing this out: I haven't touched / increased plugins individual version, since the main update has been package naming and no other feature added to the plugin itself.

@louwers
Copy link
Collaborator

louwers commented May 16, 2024

Let me know when you can build everything locally so I can run CI.

@kocheick
Copy link
Contributor Author

kocheick commented May 17, 2024

Let me know when you can build everything locally so I can run CI.

Let's gooooo

@louwers
Copy link
Collaborator

louwers commented May 17, 2024

Testing tomorrow. Will likely merge tomorrow and make a release. Thanks.

@louwers
Copy link
Collaborator

louwers commented May 20, 2024

I get this error when I try to run the sample app:

Activity class {com.mapbox.mapboxsdk.plugins.testapp/org.maplibre.android.plugins.testapp.activity.FeatureOverviewActivity} does not exist

Tried cleaning the build.

Edit: needed to clear my caches.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well!

Thanks @kocheick !

@louwers louwers merged commit 72a5729 into maplibre:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants