-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all .unwrap()
and .expect()
#92
Comments
Hello, I would love to work on the issue since it is a good Rust first issue. Any specificities I should know? |
Hello @iakev I'm merging in a rather large PR in the next 1h :) So its better to start working after that. Maybe it could make sense to leave some |
Or probably tomorrow.. |
Okay, no problem will start working on it tomorrow. In case I find any
difficulties, I presume I can contact you right?
…On Mon, May 9, 2022 at 6:59 PM Max Ammann ***@***.***> wrote:
Or probably tomorrow..
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD64W4NF5MOGTIPJ5NN5WSLVJEY4ZANCNFSM5VOCYBBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, absolutely. You can also reach me on matrix.org Its @maxammann |
Hello, I hope you are fine. So I have tweaked one file just wanted to hear
if what am doing is correct so that I can continue. Can I push the branch
for your review?
Best Regards,
Kevin Mwongera
…On Mon, May 9, 2022 at 10:52 PM Max Ammann ***@***.***> wrote:
Yes, absolutely. You can also reach me on matrix.org Its @maxammann
<https://github.com/maxammann>
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD64W4IRXY6ACNPCATAHGDDVJFUHJANCNFSM5VOCYBBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sure, just push the branch to your fork and then open a PR in "Draft Mode": https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
Thanks, I will do that. Kindly let me know your thoughts.
…On Thu, May 12, 2022 at 11:45 AM Max Ammann ***@***.***> wrote:
Sure, just push the branch to your fork and then open a PR in "Draft
Mode": https://github.blog/2019-02-14-introducing-draft-pull-requests/
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD64W4I54GW3C6AB56LDZQTVJTAKXANCNFSM5VOCYBBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi, |
Hi! The description and goal of this issue needs some refinement. Ill try to refine it this weekend! |
🤔 Expected Behavior
Return a Result for failable operations.
😯 Current Behavior
We use sometimes unwrap or expecte because of lazyness.
💁 Possible Solution
🔦 Context
💻 Examples
The text was updated successfully, but these errors were encountered: