-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Windows executable artifact in GHA #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
requested changes
May 17, 2022
The build-demo-windows action should pass as soon as #103 is merged on main. |
maxammann
reviewed
May 23, 2022
maxammann
requested changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot of files were added by accident here. But I also could be wrong and they should be there.
apple/xcode/maplibre-rs.xcodeproj/xcshareddata/xcschemes/maplibre-rs.xcscheme
Outdated
Show resolved
Hide resolved
15bb3db
to
c3ff8e6
Compare
maxammann
previously approved these changes
May 23, 2022
maxammann
approved these changes
May 23, 2022
Resolved upstream conflicts and enabled auto merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to generate a Windows executable (.exe) as an artifact in Github Actions.
馃捇 Examples
-
馃毃 Test instructions
Run the github workflow called build_demos.
鉁旓笍 PR Todo