Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Windows executable artifact in GHA #101

Merged
merged 3 commits into from
May 23, 2022

Conversation

Drabble
Copy link
Collaborator

@Drabble Drabble commented May 17, 2022

We want to generate a Windows executable (.exe) as an artifact in Github Actions.

馃捇 Examples

-

馃毃 Test instructions

Run the github workflow called build_demos.

鉁旓笍 PR Todo

  • Create a Github Action that builds a Windows executable in release mode with cargo.

@Drabble Drabble added the feature-request Request for a new feature label May 17, 2022
@Drabble Drabble self-assigned this May 17, 2022
.github/workflows/build_demos.yml Outdated Show resolved Hide resolved
.github/actions/demo/windows/action.yml Show resolved Hide resolved
@Drabble
Copy link
Collaborator Author

Drabble commented May 23, 2022

The build-demo-windows action should pass as soon as #103 is merged on main.

.idea/misc.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of files were added by accident here. But I also could be wrong and they should be there.

maxammann
maxammann previously approved these changes May 23, 2022
@maxammann
Copy link
Collaborator

Resolved upstream conflicts and enabled auto merge

@maxammann maxammann enabled auto-merge (squash) May 23, 2022 14:59
@maxammann maxammann merged commit 5daad34 into maplibre:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants