Simplify and move Stencil reference functions #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
changed the title
|
Historically they moved a little bit around in code. So thanks for moving them to the right location. I think the 2d is not used anymore. I think this would be a good PR to just remove it and document via a commit why it was removed. Here is why:
Can you remove it and commit with that message? |
maxammann
previously approved these changes
Jan 15, 2023
The 2d version of calculating the stencil value is only valid for cases where only tiles from exactly one zoom level are displayed at once. As soon as multiple zoom levels are presented at once, the stencil value needs to be distinct across zoom levels
|
Function removed! Thank you for the context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is more a question of style concerning
stencil_reference_value_2dandstencil_reference_value_3dThe first commits changes a bit how the pattern matching is written. I believe it’s a bit more “rusty” and we have the guarantee the matching is complete.
The second commit moves those functions as a member of
WorldTileCoordinstead ofTileViewPattern. I’m still missing the bigger picture of all those parts. The observation was that no information ofTileViewPatternis required to do the computation, but I’ll perfectly understand that there are broader implications.