Postponed: Experimentally render to an Android surface #99

maxammann · 2022-05-13T09:52:41Z

Thanks @MarijnS95 for making this possible! This PR experimentally renders to a surface on android: rust-mobile/ndk#272

💻 Examples

🚨 Test instructions

✔️ PR Todo

Included links to related issues/PRs

MarijnS95 · 2022-05-13T10:19:39Z

android/src/window.rs

+unsafe impl raw_window_handle::HasRawWindowHandle for AndroidNativeWindow {
+    fn raw_window_handle(&self) -> RawWindowHandle {
+        let mut handle = AndroidNdkHandle::empty();
+        handle.a_native_window = unsafe { self.window.ptr().as_mut() as *mut _ as *mut _ };
+        RawWindowHandle::AndroidNdk(handle)
+    }
+}


Yes, let me add the bindings for this one directly on ndk::NativeWindow 🎉

rust-mobile/ndk#274 Hopefully this simplifies things a bit for you, too :)

MarijnS95 · 2022-05-23T19:18:38Z

Whoops!

Updating git repository `[https://github.com/rust-windowing/android-ndk-rs.git`](https://github.com/rust-windowing/android-ndk-rs.git%60)
error: failed to get `ndk` as a dependency of package `maplibre-android v0.1.0 (/home/runner/work/maplibre-rs/maplibre-rs/android)`

Caused by:
  failed to load source for dependency `ndk`

Caused by:
  Unable to update https://github.com/rust-windowing/android-ndk-rs.git?branch=native-window-jni-surface

Caused by:
  failed to find branch `native-window-jni-surface`

Caused by:
  cannot locate remote-tracking branch 'origin/native-window-jni-surface'; class=Reference (4); code=NotFound (-3)

The branch disappeared because the PR - and the one adding HasRawWindowHandle - have both been merged 🎉! You should be able to use a rev from master now which won't disappear.

maxammann · 2022-05-25T17:50:51Z

Whoops!

Updating git repository `[https://github.com/rust-windowing/android-ndk-rs.git`](https://github.com/rust-windowing/android-ndk-rs.git%60)
error: failed to get `ndk` as a dependency of package `maplibre-android v0.1.0 (/home/runner/work/maplibre-rs/maplibre-rs/android)`

Caused by:
  failed to load source for dependency `ndk`

Caused by:
  Unable to update https://github.com/rust-windowing/android-ndk-rs.git?branch=native-window-jni-surface

Caused by:
  failed to find branch `native-window-jni-surface`

Caused by:
  cannot locate remote-tracking branch 'origin/native-window-jni-surface'; class=Reference (4); code=NotFound (-3)

The branch disappeared because the PR - and the one adding HasRawWindowHandle - have both been merged tada! You should be able to use a rev from master now which won't disappear.

Thank you! I think I'll actually wait with this until a new release is deployed :) else we can not publish to crates.io :)

MarijnS95 · 2022-05-25T17:52:02Z

That'll take a while... :(

MarijnS95 · 2022-05-27T09:23:49Z

Pinging back to #53, I couldn't find this PR from there :)

MarijnS95 · 2022-05-27T09:27:01Z

android/src/lib.rs

+        libc::pipe(logpipe.as_mut_ptr());
+        libc::dup2(logpipe[1], libc::STDOUT_FILENO);
+        libc::dup2(logpipe[1], libc::STDERR_FILENO);
+        thread::spawn(move || {
+            let tag = CStr::from_bytes_with_nul(b"MapLibreStderr\0").unwrap();
+            let file = File::from_raw_fd(logpipe[0]);
+            let mut reader = BufReader::new(file);
+            let mut buffer = String::new();
+            loop {
+                buffer.clear();
+                if let Ok(len) = reader.read_line(&mut buffer) {
+                    if len == 0 {
+                        break;
+                    } else if let Ok(msg) = CString::new(buffer.clone()) {
+                        ndk_glue::android_log(Level::Info, tag, &msg);
+                    }
+                }
+            }
+        });
+    }


CC rust-mobile/ndk#281, perhaps we should move this out of ndk_glue and make it generic :)

Perhaps some unification with the android_logger crate too.

maxammann · 2022-05-27T17:11:55Z

That'll take a while... :(

Everything below 1-2 months is fine I think :) this poc is enough for now. It wont be usable until input is working for android

MarijnS95 · 2022-05-27T22:23:33Z

I don't know what the cadence for winit is going to be, which I want to synchronize the next breaking release with. We could also have a breaking release earlier if folks are actively blocking on it, but I've previously received complaints about doing lots of breaking releases in short succession (for usually minor breaking changes in isolated parts of a crate). In this specific case I'm planning ahead some breaking changes that affect both winit and ndk so I'd like to prevent doing a release before that is over (pending exactly another breaking release in short succession). In addition people like to keep their stuff up to date, and it's annoying if they see a new ndk update but then can't upgrade because that breaks or results in duplicate dependencies with winit.

But again, let me know if/when you start depending on a release and we'll see what we can do!

maxammann · 2022-05-29T12:49:33Z

Alright! So I think right now its no problem to depend on main as we have not even an unstable release. I'll continue to work on this with very low priority though as the changes are quite isolated.

# Conflicts: # maplibre-winit/src/winit/mod.rs # maplibre/src/window.rs

Experimentally render to an Android surface

7b6ca43

maxammann force-pushed the experiement-surface-android branch from a889831 to 7b6ca43 Compare May 13, 2022 09:53

MarijnS95 reviewed May 13, 2022

View reviewed changes

Merge branch 'main' into experiement-surface-android

b550e39

MarijnS95 reviewed May 27, 2022

View reviewed changes

This was referenced May 27, 2022

Use glutin to render to Surface/NativeWindow without winit/ndk_glue rust-windowing/glutin#1324

Closed

SurfaceTexture NDK bindings rust-mobile/ndk#262

Closed

maxammann added 2 commits June 2, 2022 16:11

Merge branch 'main' into experiement-surface-android

707c193

# Conflicts: # maplibre-winit/src/winit/mod.rs # maplibre/src/window.rs

Fixes after merge

5dbff6d

maxammann force-pushed the experiement-surface-android branch from 91b59d0 to 5dbff6d Compare June 2, 2022 14:41

Merge branch 'main' into experiement-surface-android

7378764

maxammann force-pushed the main branch 3 times, most recently from 8c5d8ee to 4dbd47b Compare June 3, 2022 09:54

Merge branch 'main' into experiement-surface-android

ad48810

maxammann changed the title ~~Experimentally render to an Android surface~~ Postphoned until needed:Experimentally render to an Android surface Nov 12, 2022

maxammann changed the title ~~Postphoned until needed:Experimentally render to an Android surface~~ Postphoned until needed: Experimentally render to an Android surface Nov 12, 2022

maxammann changed the title ~~Postphoned until needed: Experimentally render to an Android surface~~ Postponed: Experimentally render to an Android surface Nov 19, 2022

maxammann added the pr-postponed Postponed PR, which is not needed right now but might be needed (contains valuable information) label Nov 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postponed: Experimentally render to an Android surface #99

Postponed: Experimentally render to an Android surface #99

maxammann commented May 13, 2022

MarijnS95 May 13, 2022

MarijnS95 May 13, 2022

MarijnS95 commented May 23, 2022

maxammann commented May 25, 2022

MarijnS95 commented May 25, 2022

MarijnS95 commented May 27, 2022

MarijnS95 May 27, 2022

maxammann commented May 27, 2022

MarijnS95 commented May 27, 2022

maxammann commented May 29, 2022

Postponed: Experimentally render to an Android surface #99

Are you sure you want to change the base?

Postponed: Experimentally render to an Android surface #99

Conversation

maxammann commented May 13, 2022

💻 Examples

🚨 Test instructions

✔️ PR Todo

MarijnS95 May 13, 2022

Choose a reason for hiding this comment

MarijnS95 May 13, 2022

Choose a reason for hiding this comment

MarijnS95 commented May 23, 2022

maxammann commented May 25, 2022

MarijnS95 commented May 25, 2022

MarijnS95 commented May 27, 2022

MarijnS95 May 27, 2022

Choose a reason for hiding this comment

maxammann commented May 27, 2022

MarijnS95 commented May 27, 2022

maxammann commented May 29, 2022