-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to describe raster-fade-duration's effect on rendering videos #297
Update docs to describe raster-fade-duration's effect on rendering videos #297
Conversation
Now that I've made this change, I guess I should ask... Does this property affect video similarly in other things that use the spec, beyond GL JS? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 100 100
Lines 4105 4105
Branches 1176 1176
=======================================
Hits 3195 3195
Misses 910 910 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!
Like what? |
What I mean is, do my new comments in the docs only apply to GL, or does native work the same way (with the fade in)? I've never used anything other than GL. |
They shouldn't, the spec should be cross platform, but just in case: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this source is not supported by MapLibre Native, it is clear that the description applies to GL JS only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes so video sources are not supported by Native, that means the addition is not relevant for Native, but it will be once videos are supported. Fine to merge I think.
Partially addresses the documentation update requested in maplibre/maplibre-gl-js#2922. Will also open a PR in that repo to mention the property in video_source.ts.
Launch Checklist
CHANGELOG.md
under the## main
section.