Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for sprite #390

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Improve documentation for sprite #390

merged 5 commits into from
Oct 20, 2023

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Oct 19, 2023

Fixes #389 - Sprite Documentation is Outdated
Add other data to that page.
Update some versions support in the v8 file.

@HarelM HarelM requested a review from birkskyum October 19, 2023 20:35
@HarelM
Copy link
Member Author

HarelM commented Oct 19, 2023

@birkskyum I was trying to make codespaces run the docs site but it didn't work well...
I did npm i in the root folder and npm i && npm run build && npm run start did I miss anything?

@HarelM HarelM requested a review from louwers October 19, 2023 20:42
@HarelM
Copy link
Member Author

HarelM commented Oct 19, 2023

@louwers did what I wrote make sense? Is it clear? Is the english OK?

@louwers
Copy link
Collaborator

louwers commented Oct 19, 2023

Can I push some changes? You can see if you like them.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b5b6cd) 78.02% compared to head (2330b02) 78.02%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         101      101           
  Lines        4142     4142           
  Branches     1184     1184           
=======================================
  Hits         3232     3232           
  Misses        910      910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louwers
Copy link
Collaborator

louwers commented Oct 19, 2023

I restructered and reworded things a bit. Hope you like it.


I think this sentence should be removed or reworded? Do you know what it is trying to say?

with the tokenized value `"icon-image": "{icon}"` and vector tile features with an `icon` property with the value `poi`.

@HarelM
Copy link
Member Author

HarelM commented Oct 20, 2023

I can't see it in comparison to the current page, did you intentionally add a md file?

@HarelM
Copy link
Member Author

HarelM commented Oct 20, 2023

I think this sentence should be removed or reworded? Do you know what it is trying to say?

Yes, it means you can use feature properies from a vector tile source to set the image icon, similar to the ["get", "icon"] in other dynamic values, I think...

@louwers
Copy link
Collaborator

louwers commented Oct 20, 2023

Oops...

@HarelM Fixed now.

@HarelM HarelM merged commit b39794a into main Oct 20, 2023
6 checks passed
@HarelM HarelM deleted the fix-389 branch October 20, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprite Documentation is Outdated
3 participants