Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for maplibre #781

Closed
pathmapper opened this issue May 7, 2022 · 7 comments · Fixed by #789 or #812
Closed

Support for maplibre #781

pathmapper opened this issue May 7, 2022 · 7 comments · Fixed by #789 or #812

Comments

@pathmapper
Copy link
Contributor

Since this topic was raised in #775, this issue is to discuss about support for maplibre: https://github.com/maplibre/maplibre-gl-js

  • mapbox-gl version 1.x. -> backward compatible to mapbox-gl

  • maplibre-gl version 2 -> non-backward compatible

@jsehner
Copy link

jsehner commented Sep 1, 2022

Please add Maplibre GL JS as Style renderer.
The library has a fast growing community.
Maputnik ist still the best open source editor, but without MapLibre losing benefit.

@lseelenbinder
Copy link
Member

Hi @pathmapper, I'd like to take a look at this, if possible. Unfortunately, I'm not well-versed in the code, so I can't estimate how much effort it would be.

I'm eager to see support for recent MapLibre improvements (e.g., 3D) in the editor! I should be able to get a few people to assist from the MapLibre community, as well, if it turns out to be more involved than expected.

(cc @nyurik)

@lseelenbinder
Copy link
Member

I've made decent progress locally, and will be pushing a draft PR with working but not perfect code tomorrow. Looks like it'll be mostly a drop-in replacement!

@tordans
Copy link

tordans commented Jul 19, 2023

@tordans
Copy link

tordans commented Jul 19, 2023

It looks like the docs are still referring to Mapbox GL JS in https://github.com/maputnik/editor#develop

@nyurik
Copy link
Member

nyurik commented Jul 19, 2023

@tordans definitly needs fixing, PRs welcome :)

@kevinschaul
Copy link
Collaborator

Good point @tordans. I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants