Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky MacOS CI test, possibly using preinstalled Github's MacOS nginx instead #1103

Closed
nyurik opened this issue Dec 25, 2023 · 2 comments · Fixed by #1104
Closed

Fix flaky MacOS CI test, possibly using preinstalled Github's MacOS nginx instead #1103

nyurik opened this issue Dec 25, 2023 · 2 comments · Fixed by #1104

Comments

@nyurik
Copy link
Member

nyurik commented Dec 25, 2023

It seems the nginx server in a docker container sometimes does not properly start up on macos hosts, so the curl --head "http://localhost:5412/webp2.pmtiles" fails to connect.

Possible solutions:

  • figure out why the docker does not start, and ensure that it does
  • it seems github macos runners have nginx natively (see script) - so perhaps we can just use that, making the test faster as well? I think this is the preferred option if possible

Context

Initially added in #991 by @kyleslugg who knows most of the context on this one.

@kyleslugg
Copy link
Contributor

kyleslugg commented Dec 25, 2023 via email

@nyurik
Copy link
Member Author

nyurik commented Dec 25, 2023

I fixed it in #1104, seem to be working, but ideally we should do the same with linux too - will make things more consistent. I do think we may want to create a simple github action for local serving without docker - should be fairly easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants