Upgrade styled componenets to v6 #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think you are missing the changes to package.json - did you modify that file too? |
jtmiclat
force-pushed
the
feature/upgrade-styled-components
branch
from
0e7bba9
to
daef924
Compare
|
@nyurik Woops forgot to commit package.json . Should be fixed now |
|
Thanks @jtmiclat ! I added a CI step to build the code, so seems to be passing. Would be great to have some sort of a integration test, but not worth it for a demo site. |
|
@jtmiclat if you have any energy, feel free to bump all other demo dependencies -- it is not as often maintained as one could hope :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #996
This PR updated styled components to v6.
In v5, styled components had no type checking by default while in v6 it is included by default so I had to add typing to the styled components props.