Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMTiles cache, refactor file configs, modularize #1094

Merged
merged 5 commits into from
Dec 25, 2023
Merged

PMTiles cache, refactor file configs, modularize #1094

merged 5 commits into from
Dec 25, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Dec 22, 2023 •
edited

  • Make it possible to have configuration specific to the file-based config sections: pmtiles, mbtiles, and sprites.
  • Implement PMTiles directory cache shared between all pmtiles (both http and local), with configurable max cache size (in MB), or 0 to disable. Defaults to 32MB (?)
  • PMTiles now share web client instance, which optimizes connection reuse in case multiple pmtiles reside on the same host
  • Major refactoring to allow modular reuse, enabling the following build features:
    • postgres - enable PostgreSQL/PostGIS tile sources
    • pmtiles - enable PMTile tile sources
    • mbtiles - enable MBTile tile sources
    • fonts - enable font sources
    • sprites - enable sprite sources
  • Use justfile in the CI

Fixes #1093

@nyurik nyurik mentioned this pull request Dec 22, 2023
Closed
4 tasks
@nyurik nyurik force-pushed the pmt-cfg-extras branch 2 times, most recently from bcba707 to a9ec08d Compare December 25, 2023 04:25
@nyurik nyurik marked this pull request as ready for review December 25, 2023 04:26
@nyurik nyurik changed the title Add pmtiles-specific configuration options PMTiles cache, refactor file configs, modularize Dec 25, 2023
@nyurik nyurik force-pushed the pmt-cfg-extras branch 2 times, most recently from 89ef808 to fe6c279 Compare December 25, 2023 04:42
@nyurik
Add pmtiles-specific configuration options
c941176 
Make it possible to have configuration specific the file-based configuration section (pmtiles, mbtiles, and sprites).

As an example, I added pmtiles cache config (unused)
@nyurik
wip
2fd5e57
@nyurik
wip
a1601ac
@nyurik
PMTiles cache, refactor file configs, modularize
962d130 
* Implement PMTiles directory cache shared between all pmtiles, with configurable max cache size (in MB), or 0 to disable.
* PMTiles now share web client instance, which optimizes connection reuse in case multiple pmtiles reside on the same host
* Major refactoring to allow modular reuse, enabling the following build features:
    * **postgres** - enable PostgreSQL/PostGIS tile sources
    * **pmtiles** - enable PMTile tile sources
    * **mbtiles** - enable MBTile tile sources
    * **fonts** - enable font sources
    * **sprites** - enable sprite sources
* Use justfile in the CI
@nyurik
Make local pmtiles also cachable
5d5eb84
@nyurik nyurik enabled auto-merge (squash) December 25, 2023 05:31
@nyurik nyurik merged commit 2def628 into maplibre:main Dec 25, 2023
18 checks passed
@nyurik nyurik deleted the pmt-cfg-extras branch December 25, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkAndshark sharkAndshark sharkAndshark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make PMTiles directory cache shared between files
2 participants
@nyurik @sharkAndshark