Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_bound.sql to return Polygon everytime #300

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Fix get_bound.sql to return Polygon everytime #300

merged 1 commit into from
Feb 12, 2022

Conversation

HackJack-101
Copy link
Contributor

To solve the bug #299 we propose a solution which expands by 1 unit the Point returned by ST_Extent() in case of a table with only one Point or with multiple Points with the same geometry.

The main problem here still that we lie about the real boundaries because of ST_Expand.

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #300 (45d9ac9) into main (44d5609) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files          14       14           
  Lines        1838     1838           
=======================================
  Hits         1020     1020           
  Misses        818      818           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d5609...45d9ac9. Read the comment docs.

Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HackJack-101

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants