Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tile boundaries in debug.html #858

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

sharkAndshark
Copy link
Collaborator

@sharkAndshark sharkAndshark commented Sep 3, 2023

Try to implement #845
Based on the method in doc:

  • The map will render an outline around each tile and the tile ID
  • The uncompressed file size of the first vector source is drawn in the top left corner of each tile, next to the tile ID.

The second one, the file size is only for the first vector source, is this misleading? I mean, will the user think it's the sum file size of all sources? @nyurik

tests/debug.html Outdated
@@ -345,6 +345,7 @@
const layers = document.getElementById('menu');
layers.appendChild(link);
}
map.showTileBoundaries = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to line 288

@nyurik
Copy link
Member

nyurik commented Sep 3, 2023

I guess it is a bit misleading, but we can always try to fix it in the maplibre lib itself

@sharkAndshark sharkAndshark marked this pull request as ready for review September 3, 2023 16:25
@sharkAndshark sharkAndshark merged commit fa451cb into maplibre:main Sep 3, 2023
16 checks passed
@sharkAndshark sharkAndshark deleted the tilebox branch September 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants