Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide pg connection password #907

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Hide pg connection password #907

merged 1 commit into from
Sep 29, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Sep 29, 2023

the output now looks like this, with the password being shown as _ instead of a real value.

Connecting to Config { user: Some("myname"), password: Some(_), dbname: Some("db"), options: None, application_name: None, ssl_mode: Prefer, host: [Tcp("localhost")], hostaddr: [], port: [5411], connect_timeout: None, tcp_user_timeout: None, keepalives: true, keepalives_idle: 7200s, keepalives_interval: None, keepalives_retries: None, target_session_attrs: Any, channel_binding: Prefer }

Fix #902

@nyurik nyurik mentioned this pull request Sep 29, 2023
@nyurik nyurik enabled auto-merge (squash) September 29, 2023 17:15
@nyurik
Copy link
Member Author

nyurik commented Sep 29, 2023

@sharkAndshark feel free to +1 if ok (this my other pending PRs)

@nyurik nyurik merged commit 73edd19 into maplibre:main Sep 29, 2023
24 checks passed
@nyurik nyurik deleted the hide-pw branch September 29, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Martin leaks database password in logs
2 participants