Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify conf parsing, separate func & tbl configs #956

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Simplify conf parsing, separate func & tbl configs #956

merged 3 commits into from
Oct 21, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 20, 2023 •
edited

  • Simplify code by adding None to the enums we use for configuration
  • Separate postgres auto-publish configuration into table and function structs

@nyurik nyurik changed the title Use SomeEnum instead of Option<SomeEnum> in cfg Simplify conf parsing, removing many Option<...> Oct 20, 2023
@nyurik
Use SomeEnum instead of Option<SomeEnum> in cfg
0733a47 
Simplify code by adding `None` to the enums we use for configuration
@nyurik nyurik changed the title Simplify conf parsing, removing many Option<...> Simplify conf parsing, separate func & tbl configs Oct 21, 2023
@nyurik nyurik merged commit e377bd6 into maplibre:main Oct 21, 2023
18 checks passed
@nyurik nyurik deleted the containers branch October 21, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkAndshark sharkAndshark Awaiting requested review from sharkAndshark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nyurik