Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change build and test to run on ubuntu, update ci action version #170

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

marcjulian
Copy link
Collaborator

@marcjulian marcjulian commented Jun 5, 2024

Change build-and-test job to run on ubuntu-latest instead of macos-latest.
Any particular reason macos-latest was used in this step?

Update also actions/checkout and actions/upload-artifact to latest version.

@marcjulian marcjulian requested a review from HarelM June 5, 2024 18:54
@marcjulian marcjulian mentioned this pull request Jun 5, 2024
@HarelM
Copy link
Member

HarelM commented Jun 6, 2024

I think I selected macos since it was easier than to setup xvfb, but apparently it isn't needed...

@HarelM HarelM merged commit a3ed3fe into main Jun 6, 2024
2 checks passed
@HarelM HarelM deleted the fix/unit-test-in-ci branch June 6, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants