Use semver to define which version to load (fix #108) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also: - dynamically builds the available versions by listing the versions directories. - introduces module.latest, that point to the latest version id available Using "semver" module, this will also allow much advanced loading syntax (like ranges, carret, star or x…).
yohanboniface
force-pushed
the
semver-load
branch
from
4d7ee30
to
69e02a6
Compare
| var getVersions = function () { | ||
| var names = fs.readdirSync('./'), versions = []; | ||
| for (var i = 0; i < names.length; i++) { | ||
| if(names[i].match(/^\d{1,2}\.\d{1,2}\.\d{1,2}$/)) versions.push(names[i]); |
There was a problem hiding this comment.
is this trying to figure out if the string is a valid semver? should this use semver.valid in a call to .filter()
This was referenced Dec 1, 2015
springmeyer
pushed a commit
that referenced
this pull request
Mar 5, 2016
|
landed in 08437ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #108
This also:
the versions directories.
id available
Using "semver" module, this will also allow much advanced loading
syntax (like ranges, carret, star or x…).
@flippmoke up for a review? :)