Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapefile reader should accept files with or without '.shp' extension #199

Closed
artemp opened this issue Oct 11, 2011 · 4 comments
Closed

Comments

@artemp
Copy link
Member

artemp commented Oct 11, 2011

No description provided.

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[artem] Hmm.. I'm not completely sure about this one. Perhaps, we should be handling both cases (with and without ext). Pushing to 0.7.0

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] Ya, it surely should handle both cases. Sorry not to make that clear.

I figure that a user should be able to put either file='world_borders' or file='world_borders.shp'

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] The attached patch offers the behavior I was envisioning. It would likely be more robust by using 'boost::filesystem::basename(shp_path)' rather than string replacement, but the above approach was quickest to code up.

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] revised patch applied in r1046

@artemp artemp closed this as completed Oct 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant