mapnik-geometry branch visual tests needing fixed

[springmeyer]

Most visual tests failing in the mapnik-geometry branch are due to improvements and are of no concern - we'll just update the visual tests after merging. But a few need fixing:

• text-iconic-font (DebugSymbolizer not working right) - 3bbb9a2
• functional-expressions is missing marker rendering (maybe something is broken with geometry_type filtering?) - fixed now, probably by 807a940
• geojson-geometry-collection (points are not rendering in geometry collection)
• simplify-zhao-saalfeld looks oddly different
• simplify-radial-distance looks oddly different

[springmeyer]

Other fixmes I'm seeing:

~/projects/mapnik/mapnik-geom[mapnik-geometry]$ grep FIXME src/ -r
src//agg/process_polygon_pattern_symbolizer.cpp:#if 0  // FIXME
src//agg/process_polygon_pattern_symbolizer.cpp:#if 0 // FIXME
src//cairo/process_polygon_pattern_symbolizer.cpp:// FIXME
src//load_map.cpp:        read_xml_string(str, tree.root(), map.base_path()); // FIXME - this value is not fully known yet
src//load_map.cpp:            // FIXME
src//memory_datasource.cpp:        // FIXME
src//png_reader.cpp:            png_set_interlace_handling(png_ptr); // FIXME: libpng bug?
src//symbolizer.cpp:// START FIXME - move to its own compilation unit
src//symbolizer.cpp:// END FIXME
src//symbolizer_keys.cpp:    property_meta_type{ "placement", // FIXME - change property name
src//symbolizer_keys.cpp:    property_meta_type{ "placement", // FIXME - change property name
src//text/formatting/format.cpp:    //set_property_from_xml<double>(n->halo_opacity, "halo-opacity", xml); FIXME
src//text/placements/list.cpp:        list_.push_back(last); //Preinitialize with old values FIXME
src//text/symbolizer_helpers.cpp:    if (!geometries_to_process_.size()) return; // FIXME - bad practise
src//text/symbolizer_helpers.cpp:    // FIXME: how to handle MultiLinePolygon
src//text/symbolizer_helpers.cpp:    // FIXME: return early if geometries_to_process_.empty() ?
src//text/symbolizer_helpers.cpp:            // FIXME: how to handle MultiLineString?
src//transform_expression.cpp:    std::ostringstream os; // FIXME set precision?
src//transform_expression.cpp:    std::ostringstream os; // FIXME set precision?
src//xml_tree.cpp:    // FIXME : return boost::optional<std::string const&>
~/projects/mapnik/mapnik-geom[mapnik-geometry]$ grep FIXME include/ -r
include//mapnik/feature_style_processor_impl.hpp:    scale_denom *= p.scale_factor(); // FIXME - we might want to comment this out
include//mapnik/hit_test_filter.hpp:        // FIXME
include//mapnik/json/properties_generator_grammar_impl.hpp:    // FIXME http://boost-spirit.com/home/articles/karma-examples/creating-your-own-generator-component-for-spirit-karma/
include//mapnik/params_impl.hpp:        return boost::optional<mapnik::value_null>(); // FIXME
include//mapnik/svg/svg_converter.hpp:    // FIXME!!!!
include//mapnik/svg/svg_storage.hpp:    VertexSource & source() // FIXME!! make const
include//mapnik/svg/svg_storage.hpp:    AttributeSource & attributes() // FIXME!! make const
include//mapnik/symbolizer_default_values.hpp:// placement (point-placement-type FIXME)
include//mapnik/symbolizer_hash.hpp:        return 0; //FIXME
include//mapnik/symbolizer_hash.hpp:        return 0; //FIXME
include//mapnik/symbolizer_hash.hpp:        return 0; //FIXME
include//mapnik/symbolizer_hash.hpp:        return 0; //FIXME
include//mapnik/symbolizer_utils.hpp:            ss << '\"' << "FIXME" <<  '\"';
include//mapnik/util/container_adapter.hpp:// FIXME

[springmeyer]

visual tests are looking better, but still a few failing in odd ways. I'm going to close this now, let's attack the core issues that need fixed and I think the visual tests will be fixed in the process. So, https://github.com/mapnik/mapnik/labels/mapnik-geometry is the new focus.