Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextSymbolizer deprecate name in favour of content #3720

Open
nebulon42 opened this issue Jul 6, 2017 · 1 comment
Open

TextSymbolizer deprecate name in favour of content #3720

nebulon42 opened this issue Jul 6, 2017 · 1 comment

Comments

@nebulon42
Copy link

It has been suggested at the carto repository to replace text-name with text-content (ref mapbox/carto#347), which would correspond to <TextSymbolizer name="..."/> vs. <TextSymbolizer content="..."/>.

This change has to come from Mapnik as carto (or more precisely mapnik-reference) cannot map two different css names to one attribute name.

I also think name is not the most accurate label for what the attribute does so I would suggest to deprecate it in 3.1 and to make content the new default.

@lightmare
Copy link
Contributor

name attribute has been removed from (or more precisely, silently ignored in) TextSymbolizer (06ec0c3) and ShieldSymbolizer (6ce55a0) for a long time.
content attribute is also not recognized, what you refer to is the element's text content:

<TextSymbolizer> "here's content, a mapnik expression" </TextSymbolizer>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants