New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road to v4 #4299
Comments
@mathisloge - My thinking -> I still didn't have time to properly look into |
@artemp agree that https://github.com/mapnik/mapnik/blob/bb1bc2f07bdd85ed76d2dfa07a46670fa8b53769/src/mapnik.cpp e.g. #ifndef MAPNIK_STATIC_DEFINE
bool shared_init_complete = mapnik::setup();
#endif or without the macro and just always call the setup method. If the compiler then removes the dynamic init call, the user must add it. Should only be necessary if compiled statically. With those changes we can introduce #4291 without silently breaking users code (bc. they are unaware of the setup method) and loudly fail users with custom plugins because compilation will fail. |
@mathisloge sounds good! Avoiding macro feels more c++ but your call. It might be easier to |
This is mostly a todo list for me.
@artemp there is a v4 Milestone, which are some must haves of those?
mapnik::setup()
method needs to be called in python-mapnik and node-mapnikThe text was updated successfully, but these errors were encountered: