Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JPEG dependency optional #545

Closed
artemp opened this issue Oct 11, 2011 · 2 comments
Closed

Make JPEG dependency optional #545

artemp opened this issue Oct 11, 2011 · 2 comments
Milestone
Mapnik 2.0

Comments

@artemp
Copy link
Member

artemp commented Oct 11, 2011

Most Mapnik users rely on PNG output, even though Mapnik supports also writing to JPEG output. JPEG output is particularly useful for raster tiles, but for users that don't serve rasters (and will not in the future (#518) be interested in reading JPEG symbol files) being able to skip the jpeg dependency offers a small convenience.

The patch at #463 was originally provided with JPEG support commented, which originally prompted this idea.

Draft patch making JPEG support a SCons option (on by default) is attached for review.
@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] patch needs more testing - in particular, I noticed thatextern "C" and image library includes may not be needed in python bindings (at least for g++ compiler). Need to look into this in more detail in a free moment.

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] extern C needs to stay, on linux at least.

Since I've heard to qualms with this, I've now fixed up the patch, and committed in r1829

@artemp artemp closed this as completed Oct 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mapnik 2.0
Development

No branches or pull requests
1 participant
@artemp