Fixed bug in shield line placement #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the label relative to the placement point.
springmeyer
pushed a commit
that referenced
this pull request
Oct 17, 2011
Fixed bug in shield line placement
springmeyer
pushed a commit
that referenced
this pull request
Oct 17, 2011
springmeyer
pushed a commit
that referenced
this pull request
Oct 17, 2011
kkaefer
pushed a commit
to kkaefer/mapnik
that referenced
this pull request
Feb 16, 2012
Fixed bug in shield line placement
kkaefer
pushed a commit
to kkaefer/mapnik
that referenced
this pull request
Feb 16, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a bug with shield+text placement along a line. it seems what was happening previously was that the label box was being expanded to the size of the shield and being used to place text. however, this was not giving the right answer where dx/dy were being used. the patch expands line placement to include "additional boxes", i.e: when searching for a line placement it checks that some boxes offset from the position can be
placed.