Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing of area_threshold option #471

Closed
springmeyer opened this issue Jun 29, 2015 · 1 comment
Closed

Incorrect parsing of area_threshold option #471

springmeyer opened this issue Jun 29, 2015 · 1 comment
Assignees
@flippmoke
Milestone
v3.4.1

Comments

@springmeyer
Copy link
Member

The area_threshold option is parsed as an integer rather than a double here which means that area_threshold=0.5 gets converted incorrectly to 0.
@springmeyer springmeyer added this to the v3.4.0 milestone Jun 29, 2015
@springmeyer
Copy link
Member Author

Not a hard fix, but needs tests. I noticed that fixing it locally did not trigger any test differences which is not good: Our test results should be sensitive to this parameter changing.

@springmeyer springmeyer modified the milestones: v3.5.0, v3.4.0 Jul 2, 2015
@springmeyer springmeyer modified the milestones: v3.4.1, v3.5.0 Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flippmoke flippmoke

Labels
None yet
Projects
None yet
Milestone
v3.4.1
Development

No branches or pull requests
2 participants
@springmeyer @flippmoke