Support LIB_DIR_NAME environment variable for custom mapniklibpath #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No comments on this? |
|
@sebastic - looking good, I'm going to merge your PR. |
|
@sebastic - thanks! |
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Debian Bug #803564 and issue #62, the hardcoded
mapniklibpathinpaths.pyis not correct when mapnik has been built using a customLIB_DIR_NAME.The mapnik Debian package is built using
LIB_DIR_NAME=/mapnik/3.0for which this change adds support insetup.pyfor the python-mapnik build. It's quite similar to thefontscollectionpathchange from #59.Instead of, or in addition to, supporting custom paths using environment variables, may be
mapnik-configshould be used to retrieve the paths and fallback to the environment variables and hardcoded paths when unavailable.build.pyuses theMAPNIK_LIB_DIRenvironment variable to set the path formapniklibpathinpaths.py, that's also an option instead of specifying only part of the path withLIB_DIR_NAME.