Add some explicit register_ptr_to_python calls #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mapnik and python-mapnik are built with boost 1.60 then various python-mapnik test fail with errors like there:
There are reports of similar issues at http://permalink.gmane.org/gmane.comp.python.c++/16601 and in the comments of boostorg/python#29 and it seems that the issue is that the shared pointers are being implicitly registered when used in the class definitions, but it seems to be unclear if this was a deliberate change or not.
This patch adds enough
register_ptr_to_python
calls to get the tests passing, but it's possible that there are others that need to be added that aren't caught be the calls - there are definitely others without explicit registration but it's not clear if the tests just aren't catching them or if they aren't a problem.