Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace precision values like 0.000 with 0 #20

Closed
eightysteele opened this issue Nov 13, 2012 · 5 comments
Closed

Replace precision values like 0.000 with 0 #20

eightysteele opened this issue Nov 13, 2012 · 5 comments
Assignees

Comments

@eightysteele
Copy link

Again, just a space saver.

@ghost ghost assigned robinkraft Nov 13, 2012
@robinkraft
Copy link

So I've got things worked out for the truncating such that

3.4 -> "3.4"
3.4444444444 -> "3.4444444"
3.00 -> "3.0"

Is it worth special-casing precision to force int zeros, or is this behavior we want everywhere?

Also, do we actually want all possible ints to be stored as such?

3.0 -> "3".

@robinkraft
Copy link

Just added support for that last option: 3.0000000 -> "3"

@eightysteele
Copy link
Author

Nice dude. LGTM.

@robgur
Copy link
Member

robgur commented Nov 13, 2012

Hmmm. I wouldn't mind a Tuco check. Precision on decimals might be a
place where we want to keep 3.00 and 3.0 as "3.0" as opposed to "3".
-r

On Tue, Nov 13, 2012 at 1:53 PM, Aaron Steele notifications@github.comwrote:

Nice dude. LGTM.


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-10343087.

@eightysteele
Copy link
Author

OK just pinged tuco.
On Nov 13, 2012 3:32 PM, "Rob" notifications@github.com wrote:

Hmmm. I wouldn't mind a Tuco check. Precision on decimals might be a
place where we want to keep 3.00 and 3.0 as "3.0" as opposed to "3".
-r

On Tue, Nov 13, 2012 at 1:53 PM, Aaron Steele notifications@github.comwrote:

Nice dude. LGTM.


Reply to this email directly or view it on GitHub<
https://github.com/MapofLife/fossa/issues/20#issuecomment-10343087>.


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-10348800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants