Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Pandas' read_csv throwing a warning #320 #321

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fixes Pandas' read_csv throwing a warning #320 #321

merged 1 commit into from
Oct 12, 2022

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Oct 11, 2022 •
edited
Loading

Fixes warning displayed as per #320

@hrshdhgd hrshdhgd changed the title Fixes Pandas' read_csv throws a warning #320 Fixes Pandas' read_csv throwing a warning #320 Oct 11, 2022
matentzn
matentzn approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now ok, but in future would probably good to link why this solution is preferable to any other, less obvious ones :) Dont worry for now!

@hrshdhgd
Copy link
Contributor Author

From pandas documentation:
Internally process the file in chunks, resulting in lower memory use while parsing, but possibly mixed type inference. To ensure no mixed types either set False, or specify the type with the dtype parameter. Note that the entire file is read into a single DataFrame regardless, use the chunksize or iterator parameter to return the data in chunks. (Only valid with C parser)

@hrshdhgd hrshdhgd merged commit 9a0b8ab into master Oct 12, 2022
@hrshdhgd hrshdhgd deleted the issue-320 branch October 12, 2022 15:10
cthoyt added a commit that referenced this pull request Jan 13, 2024
@hrshdhgd @cthoyt @matentzn
Improve testing of round trip serialization (#480)
f40a1c8 
Fixes #321

---------

Co-authored-by: Charles Tapley Hoyt <cthoyt@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hrshdhgd @matentzn